Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in SSR docs #3386

Merged
merged 19 commits into from
May 11, 2023
Merged

Fix memory leak in SSR docs #3386

merged 19 commits into from
May 11, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented May 1, 2023

This PR contains massive changes related to dependencies to get SSG running.

Side effects:

  • Updated Nuxt to 3.4.* - faster build
  • Updated vue-tsc - better typescript support for our UI components (emit types)
  • Updated TS to 5.0 in UI lib.

Need QA.

@m0ksem m0ksem added the docs packages/docs label May 1, 2023
@m0ksem m0ksem self-assigned this May 1, 2023
@m0ksem m0ksem requested a review from RVitaly1978 May 2, 2023 01:11
@m0ksem m0ksem added the build Build process label May 2, 2023
@m0ksem m0ksem marked this pull request as ready for review May 2, 2023 01:12
@m0ksem m0ksem changed the title SSG docs, dependencies sync and Nuxt upgrade to 3.4.1 Fix memory leak in SSR docs May 4, 2023
@@ -17,7 +17,7 @@
"@ag-grid-community/vue3": "^29.0.0"
},
"peerDependencies": {
"vuestic-ui": "^1.3.0"
"vuestic-ui": "1.6.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ^1.6.4?

"inquirer": "^9.0.0",
"typescript": "^4.3.2",
"chalk": "^5.0.1"
"typescript": "4.7.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 5?

packages/docs/nuxt.config.ts Outdated Show resolved Hide resolved
packages/docs/package.json Outdated Show resolved Hide resolved
"pathe": "^0.3.5",
"vuestic-ui": "^1.4.10"
"vuestic-ui": "1.6.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be 1.6.4.

@@ -31,21 +31,21 @@
"vue": "*"
},
"devDependencies": {
"@vitejs/plugin-vue": "^1.3.0",
Copy link
Member

@asvae asvae May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can:

  • use * for non library projects (docs/sandbox)
  • use ^1.2.3 for library projects (ui, ag-grid-pluign)

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@@ -1,4 +1,15 @@
import type { ComponentOptionsBase, PropType, ExtractPropTypes } from 'vue'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have props in docs for now.

image

tsconfig.json Outdated
@@ -1,22 +1,26 @@
{
"compilerOptions": {
"target": "esnext",
"target": "es2018",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

tsconfig.json Outdated
"module": "esnext",
"strict": true,
"jsx": "preserve",
"importHelpers": true,
"moduleResolution": "node",
"skipLibCheck": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can double check these changes?

Maybe we can delete this root tsconfig for good.

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤟

@asvae asvae merged commit d6fbc38 into develop May 11, 2023
@asvae asvae deleted the chore/docs-ssg-test branch August 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build process docs packages/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants